Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement spotbugs linter aspect #442

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

nlou9
Copy link
Contributor

@nlou9 nlou9 commented Dec 4, 2024

Description:
Add spotbugs in rules_lint.

Test:
bazel build //...
bazel test//...
run bazel lint //... under example

Co-authored-by: Farid Zakaria [email protected]
Co-authored-by: Vince Rose [email protected]
Co-authored-by: Na Lou [email protected]

Co-authored-by: Farid Zakaria <[email protected]>
Co-authored-by: Vince Rose<[email protected]>
Co-authored-by: Na Lou <[email protected]>
@nlou9 nlou9 marked this pull request as ready for review December 4, 2024 00:13
MODULE.bazel Outdated Show resolved Hide resolved
example/.bazelrc Outdated Show resolved Hide resolved
lint/spotbugs.bzl Outdated Show resolved Hide resolved
@alexeagle
Copy link
Member

Just need to bazel run docs:update (I tried but doesn't seem I have permission to push to your fork)

Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

README.md Show resolved Hide resolved
lint/spotbugs.bzl Show resolved Hide resolved
@nlou9
Copy link
Contributor Author

nlou9 commented Dec 17, 2024

Just need to bazel run docs:update (I tried but doesn't seem I have permission to push to your fork)

interesting. I run bazel run docs:update locally. It has nothing to commit. and bazel test //docs:update_8_test passed locally. Wonder what could be different. It seems the current main branch also has this failure.

@alexeagle
Copy link
Member

Yeah #448 landed on red somehow. main is fixed now so could you rebase pls?

@airlock-confluentinc airlock-confluentinc bot force-pushed the nllou/spotbugs branch 2 times, most recently from 4c212b1 to ccc14fa Compare December 17, 2024 17:56
@nlou9
Copy link
Contributor Author

nlou9 commented Dec 17, 2024

Yeah #448 landed on red somehow. main is fixed now so could you rebase pls?

merge main into my branch

@alexeagle alexeagle merged commit b4c90f0 into aspect-build:main Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants